Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree DDS EditManager fixes and tests #11609

Merged
merged 8 commits into from Aug 20, 2022
Merged

Tree DDS EditManager fixes and tests #11609

merged 8 commits into from Aug 20, 2022

Conversation

yann-achard-MS
Copy link
Contributor

EditManager Changes

  • Removed invalid expectation that seq numbers received by a DDS are sequential
  • Fixed some off-by-one errors
  • Added support for refs to the non-existent edit at the start of history
  • Added more doc comments to clarify logic and invariants
  • Added a fast path to avoid needless rebasing when a new change for a branch is based on nothing but that branch

Changes to Tests

  • Added an additional assert that verifies rebase operation are always valid
  • Changed the TestChangeRebaser to make the expected value of input and output contexts less arbitrary and less opaque.
  • Fixed invalid test scenarios

@yann-achard-MS yann-achard-MS requested a review from a team as a code owner August 19, 2022 22:39
@github-actions github-actions bot added area: dds Issues related to distributed data structures base: main PRs targeted against main branch labels Aug 19, 2022
alex-pardes
alex-pardes approved these changes Aug 19, 2022
View reviewed changes
packages/dds/tree/src/edit-manager/editManager.ts Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/edit-manager/editManager.ts Outdated Show resolved Hide resolved
yann-achard-MS and others added 3 commits August 19, 2022 16:40
@yann-achard-MS @alex-pardes
Apply suggestions from code review
853d294 
Co-authored-by: alex-pardes <105307164+alex-pardes@users.noreply.github.com>
@yann-achard-MS
seqNumber monotonicity check
4e8e27e
@yann-achard-MS
Don't reuse short codes manually
623ce4f
@yann-achard-MS yann-achard-MS merged commit 2d06f39 into microsoft:main Aug 20, 2022
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

@snyk-bot snyk-bot mentioned this pull request Nov 4, 2022
Open
This was referenced Nov 4, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 5, 2022
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
This was referenced Nov 5, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-pardes alex-pardes alex-pardes approved these changes

Assignees
No one assigned
Labels
area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yann-achard-MS @alex-pardes