Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float version when installing aria-logger in ADO pipelines #11623

Merged
merged 1 commit into from Aug 23, 2022

Conversation

alexvy86
Copy link
Contributor

Description

Undoing change discussed here, so the pipelines install the latest version of aria-logger instead of a pinned one.

Significant changes in aria-logger that could cause issues on the pipeline workflows seem like they would be infrequent enough that we'd rather remove the pain point of having to update that version manually every time, and deal with the sporadic break if/when they show up.

@alexvy86 alexvy86 requested a review from a team as a code owner August 22, 2022 21:59
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Aug 22, 2022
@alexvy86 alexvy86 merged commit ab29600 into microsoft:main Aug 23, 2022
@alexvy86 alexvy86 deleted the float-aria-logger-version branch August 23, 2022 18:01
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

alexvy86 added a commit to alexvy86/FluidFramework that referenced this pull request Aug 25, 2022
alexvy86 added a commit to alexvy86/FluidFramework that referenced this pull request Aug 25, 2022
tylerbutler pushed a commit that referenced this pull request Aug 25, 2022
* Update scope for npm dependencies and pin aria-logger version (#11615)
* Float version when installing aria-logger (#11623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants