Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @fluidframework/counter API docs to website nav #11635

Merged

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Aug 23, 2022

image

Also update package to use strict API-Extractor configuration, and updated some comments.

@Josmithr Josmithr requested a review from a team as a code owner August 23, 2022 18:17
@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Aug 23, 2022
@Josmithr Josmithr requested a review from a team as a code owner August 23, 2022 18:35
@github-actions github-actions bot added the area: dds Issues related to distributed data structures label Aug 23, 2022
@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:499) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.eot (HTTP 503)
- (1:929) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.ttf (HTTP 503)
- (1:1031) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.svg (HTTP 503)
- (1:1184) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot (HTTP 503)
- (1:1272) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot? (HTTP 503)
- (1:1634) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.ttf (HTTP 503)
- (1:1740) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.svg (HTTP 503)
- (1:1897) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.eot (HTTP 503)
- (1:2427) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.svg (HTTP 503)
- (1:2581) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.eot (HTTP 503)
- (1:2668) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.eot? (HTTP 503)
- (1:3025) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.ttf (HTTP 503)
- (1:3130) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.svg (HTTP 503)
- (1:3286) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot (HTTP 503)
- (1:3369) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot? (HTTP 503)
- (1:3811) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.svg (HTTP 503)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer
- (873:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (877:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (885:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (914:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer/
- (873:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (877:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (885:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (914:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)


Stats:
  121031 links
    1316 destination URLs
       1 URLs ignored
       8 warnings
      16 errors


@Josmithr Josmithr merged commit a3831e7 into microsoft:main Aug 23, 2022
@Josmithr Josmithr deleted the docs/add-counter-api-docs-to-site-nav branch August 23, 2022 23:18
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants