Skip to content

Comments

Change logger signature.#11636

Merged
tylerbutler merged 2 commits intomicrosoft:mainfrom
tylerbutler:cli/logger
Aug 24, 2022
Merged

Change logger signature.#11636
tylerbutler merged 2 commits intomicrosoft:mainfrom
tylerbutler:cli/logger

Conversation

@tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Aug 23, 2022

The logger interface is used to enable existing build-tools to use the same logging infra as the new tools with minimal changes. After using the interface for a few weeks, I think these changes to the method names remove a lot of duplicate words in code. For example, logger.logVerbose() becomes logger.verbose(), or even log.verbose() if desired.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Aug 23, 2022
@tylerbutler tylerbutler marked this pull request as ready for review August 23, 2022 20:53
Copy link
Contributor

@RishhiB RishhiB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerbutler tylerbutler merged commit d632685 into microsoft:main Aug 24, 2022
@tylerbutler tylerbutler deleted the cli/logger branch August 24, 2022 20:09
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

tyler-cai-microsoft pushed a commit to tyler-cai-microsoft/FluidFramework that referenced this pull request Aug 26, 2022
The logger interface is used to enable existing build-tools to use the same logging infra as the new tools with minimal changes. After using the interface for a few weeks, I think these changes to the method names remove a lot of duplicate words in code. For example, logger.logVerbose() becomes logger.verbose(), or even log.verbose() if desired.
WayneFerrao pushed a commit to WayneFerrao/FluidFramework that referenced this pull request Aug 31, 2022
The logger interface is used to enable existing build-tools to use the same logging infra as the new tools with minimal changes. After using the interface for a few weeks, I think these changes to the method names remove a lot of duplicate words in code. For example, logger.logVerbose() becomes logger.verbose(), or even log.verbose() if desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants