Automation: Main Next Integrate #11637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Test telemetry indicates that this test has`"R11s fetch error: {\"code\":\"NotFoundError\", ...` during snapshot fetch at loading, This test is expected to throw on connection instead. Additionally, the test doesn't fail from having a different error from expected.
The root cause is that we didn't pass in the resolved URL, because t9s/r11s/afr assign container id and don't use the "name hint".
Fixed it by pass it into `createContainerUrl`.
Additionally, change the test to be more strict about what kind of error it is expecting, so that it doesn't hide hidden issue in the future.
Fills in `SharedCounter` article for fluidframework.com. Also... - cleans up some surrounding documentation and related source-code comments. - removes some empty articles that were hidden from the website, and had no comments or anything in them - updates page ordering to reflect current navigation
github-actions
bot
requested review from
msfluid-bot and
a team
as code owners
⯅ @fluid-example/bundle-size-tests: +17.53 KB
Baseline commit: 632468f |
sonalivdeshpande
approved these changes
Aug 24, 2022
sonalivdeshpande
deleted the
main-next-77b3c86a81543c81a2ea94ec66cceb7c128519d3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main-next integrate PR
The aim of this pull request is to sync main and next branch. The expectation from the assignee is as follows:
For more information about how to resolve merge conflicts and CI failures, visit [this wiki page]
(https://github.com/microsoft/FluidFramework/wiki/Main-next-Automation).