Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update dependencies in docs project (#11633)" #11641

Merged
merged 1 commit into from Aug 24, 2022

Conversation

tylerbutler
Copy link
Member

This reverts commit 77b3c86.

It broke the navigation on ff.com.

@tylerbutler tylerbutler marked this pull request as ready for review August 24, 2022 16:40
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners August 24, 2022 16:40
@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Aug 24, 2022
@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:1272) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot? (HTTP 503)
- (1:1740) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.svg (HTTP 503)
- (1:3286) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot (HTTP 503)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer
- (873:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (877:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (885:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (914:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer/
- (873:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (877:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (885:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (914:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)

http://localhost:1313/docs/concepts/summarizer/
- (968:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)
- (999:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)
- (1039:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)


Summary of most serious issues:

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:1272) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot? (HTTP 503)
- (1:1740) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.svg (HTTP 503)
- (1:3286) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot (HTTP 503)

http://localhost:1313/docs/concepts/summarizer/
- (968:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)
- (999:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)
- (1039:0) <script> => https://unpkg.com/mermaid@8.7/dist/mermaid.min.js (connection failed)


Stats:
  121031 links
    1316 destination URLs
       1 URLs ignored
      11 warnings
       4 errors


@tylerbutler tylerbutler merged commit 6557cb6 into microsoft:main Aug 24, 2022
@tylerbutler tylerbutler deleted the revert branch August 24, 2022 16:57
@tylerbutler
Copy link
Member Author

Thanks @RishhiB and @Josmithr!

@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants