Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ISummaryConfigurationHeuristics.idleTime #11644

Merged
merged 2 commits into from Aug 24, 2022
Merged

Remove ISummaryConfigurationHeuristics.idleTime #11644

merged 2 commits into from Aug 24, 2022

Conversation

kian-thompson
Copy link
Contributor

AB#762

For more information about how to contribute to this repo, visit this page.

Description

Deprecated by AB#128 and #10008.

Does this introduce a breaking change?

Please move all usage to the new minIdleTime and maxIdleTime properties in ISummaryConfigurationHeuristics.

@kian-thompson kian-thompson requested review from msfluid-bot and a team as code owners August 24, 2022 17:24
@github-actions github-actions bot added area: driver Driver related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file public api change Changes to a public API base: next PRs targeted against next branch labels Aug 24, 2022
NicholasCouri
NicholasCouri approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@NicholasCouri NicholasCouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 24, 2022 •
edited

⯅ @fluid-example/bundle-size-tests: +17.5 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 392.45 KB 394.75 KB ⯅ +2.3 KB
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 191.92 KB 197.47 KB ⯅ +5.54 KB
loader.js 151.12 KB 151.06 KB ⯆ -57 Bytes
map.js 42.63 KB 47.38 KB ⯅ +4.75 KB
matrix.js 131.63 KB 134.98 KB ⯅ +3.35 KB
odspDriver.js 150.23 KB 150.11 KB ⯆ -127 Bytes
odspPrefetchSnapshot.js 38.39 KB 38.35 KB ⯆ -41 Bytes
sharedString.js 152.42 KB 154.2 KB ⯅ +1.77 KB
Total Size 1.25 MB 1.27 MB ⯅ +17.5 KB

Baseline commit: 632468f

Generated by 🚫 dangerJS against 9b1703a

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Aug 24, 2022
@msftbot
Copy link
Contributor

msftbot bot commented Aug 24, 2022

Hello @kian-thompson!

Because this pull request has the msftbot: merge-next label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@msftbot msftbot bot merged commit 6f1be9d into microsoft:next Aug 24, 2022
@kian-thompson kian-thompson deleted the 762-remove-idletime branch August 24, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasCouri NicholasCouri NicholasCouri approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: driver Driver related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch breaking change This PR or issue would introduce a breaking change msftbot: merge-next public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kian-thompson @msfluid-bot @NicholasCouri