Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to GC Sweep Tests #11648

Merged

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Aug 24, 2022

AB#1586

Adds documentation and comments for the GC Sweep Tests

Please give any feedback on anything that may not be well documented enough.

@tyler-cai-microsoft tyler-cai-microsoft requested a review from a team as a code owner August 24, 2022 19:03
@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Aug 24, 2022
tyler-cai-microsoft and others added 2 commits August 25, 2022 16:47
Co-authored-by: Navin Agarwal <45832642+agarwal-navin@users.noreply.github.com>
Copy link
Contributor

@agarwal-navin agarwal-navin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can check this in for now and we can revisit as the test evolves.

tyler-cai-microsoft and others added 21 commits August 26, 2022 20:25
The logger interface is used to enable existing build-tools to use the same logging infra as the new tools with minimal changes. After using the interface for a few weeks, I think these changes to the method names remove a lot of duplicate words in code. For example, logger.logVerbose() becomes logger.verbose(), or even log.verbose() if desired.
Co-authored-by: Craig Macomber <Craig.Macomber@microsoft.com>
* Update fluid-fetch documentation
…microsoft#11652)

The tinylicious tests infrequently but consistently fail with 502 error code. The node (Axios) server socket timeout is 15s, whereas the underlying socket closes by default after 5s of inactivity. This PR switches to using agentkeepalive package to force the Node server to understand and close connections idle sockets after 4 seconds so that Node doesn't try to use an already closed socket.
The solutions to this type checking issue come with their own issues so it was decided to keep things in their current state and work towards keeping JsonableTree out of public APIs as well as rely on testing to catch these issues.
* Print errors at the end of the memory tests

* Consolidate log statements
* New npm scripts to run perf-tests
* New tool to process perf test output files
* Pipeline to run perf benchmarks and send metrics to Kusto
* Update dependencies on @fluid-tools/benchmark to 0.42.0
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution.
- Ability to add a user-specified category to tests, for selective execution.

Specifically for memory tests:
- Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones.
- Print the computed statistics to the output file when using the custom mocha reporter.
- Unit tests for function that computes statistics.
tylerbutler and others added 3 commits August 26, 2022 22:25
This change adds tests for the generate buildVersion CLI command and updates the code so that it reads environment variables correctly.
* Fix gc dataStore no duplicate routes test
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: runtime Runtime related issues area: server Server related issues (routerlicious) dependencies Pull requests that update a dependency file public api change Changes to a public API labels Aug 26, 2022
@tyler-cai-microsoft tyler-cai-microsoft merged commit fde0d5a into microsoft:main Aug 26, 2022
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

WayneFerrao pushed a commit to WayneFerrao/FluidFramework that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dds: propertydds area: dds Issues related to distributed data structures area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants