New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation to GC Sweep Tests #11648
Merged
tyler-cai-microsoft
merged 27 commits into
microsoft:main
from
tyler-cai-microsoft:document-gc-sweep-tests
Aug 26, 2022
Merged
Add documentation to GC Sweep Tests #11648
tyler-cai-microsoft
merged 27 commits into
microsoft:main
from
tyler-cai-microsoft:document-gc-sweep-tests
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Navin Agarwal <45832642+agarwal-navin@users.noreply.github.com>
agarwal-navin
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You can check this in for now and we can revisit as the test evolves.
The logger interface is used to enable existing build-tools to use the same logging infra as the new tools with minimal changes. After using the interface for a few weeks, I think these changes to the method names remove a lot of duplicate words in code. For example, logger.logVerbose() becomes logger.verbose(), or even log.verbose() if desired.
Post-release major bump of build-tools.
Co-authored-by: Craig Macomber <Craig.Macomber@microsoft.com>
Post-release minor bump of build-tools.
* Update fluid-fetch documentation
…microsoft#11652) The tinylicious tests infrequently but consistently fail with 502 error code. The node (Axios) server socket timeout is 15s, whereas the underlying socket closes by default after 5s of inactivity. This PR switches to using agentkeepalive package to force the Node server to understand and close connections idle sockets after 4 seconds so that Node doesn't try to use an already closed socket.
The solutions to this type checking issue come with their own issues so it was decided to keep things in their current state and work towards keeping JsonableTree out of public APIs as well as rely on testing to catch these issues.
* Print errors at the end of the memory tests * Consolidate log statements
…y-inspector-table (microsoft#11569)
* New npm scripts to run perf-tests * New tool to process perf test output files * Pipeline to run perf benchmarks and send metrics to Kusto * Update dependencies on @fluid-tools/benchmark to 0.42.0
* Attempt to address AB 357
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution. - Ability to add a user-specified category to tests, for selective execution. Specifically for memory tests: - Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones. - Print the computed statistics to the output file when using the custom mocha reporter. - Unit tests for function that computes statistics.
This change adds tests for the generate buildVersion CLI command and updates the code so that it reads environment variables correctly.
* Fix gc dataStore no duplicate routes test
|
This commit is queued for merging with the |
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
* Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: build
Build related issues
area: dds: propertydds
area: dds
Issues related to distributed data structures
area: runtime
Runtime related issues
area: server
Server related issues (routerlicious)
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
dependencies
Pull requests that update a dependency file
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#1586
Adds documentation and comments for the GC Sweep Tests
Please give any feedback on anything that may not be well documented enough.