Tree: cleanup and use checkout #11650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
alex-pardes
approved these changes
Aug 24, 2022
| import { StoredSchemaRepository } from "../schema-stored"; | ||
| import { Index, SharedTreeCore } from "../shared-tree-core"; | ||
| import { Checkout, runSynchronousTransaction, TransactionResult } from "../transaction"; | ||
| import { Checkout as TransactionCheckout, runSynchronousTransaction } from "../transaction"; |
There was a problem hiding this comment.
It doesn't look like Checkout would conflict with anything. Is this alias intentional, or an artifact of a previous state of the code?
There was a problem hiding this comment.
This was intentional, though it turns out there isn't a name collision because this this checkout does not use the I Prefix like the other one does. We should fix then, and then they will collide.
noencke
approved these changes
Aug 24, 2022
|
This commit is queued for merging with the |
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Aug 26, 2022
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.