Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmark tool #11661

Merged
merged 5 commits into from Aug 26, 2022
Merged

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Aug 24, 2022

Description

Some improvements to the benchmark tool:

  • benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution.
  • Ability to add a user-specified category to tests, for selective execution.

Specifically for memory tests:

  • Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones.
  • Print the computed statistics to the output file when using the custom mocha reporter.
    • With this, the post-processing tool to send telemetry to Kusto won't have to recompute those numbers and will not need to know if the test configuration indicated that lowest/highest samples were to be dropped.
  • Unit tests for function that computes statistics.

@alexvy86 alexvy86 requested review from msfluid-bot and a team as code owners August 24, 2022 22:52
@github-actions github-actions bot added the base: main PRs targeted against main branch label Aug 24, 2022
@alexvy86 alexvy86 merged commit 4370ef5 into microsoft:main Aug 26, 2022
@alexvy86 alexvy86 deleted the improve-benchmark-tool branch August 26, 2022 18:31
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

tyler-cai-microsoft pushed a commit to tyler-cai-microsoft/FluidFramework that referenced this pull request Aug 26, 2022
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution.
- Ability to add a user-specified category to tests, for selective execution.

Specifically for memory tests:
- Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones.
- Print the computed statistics to the output file when using the custom mocha reporter.
- Unit tests for function that computes statistics.
@alexvy86 alexvy86 mentioned this pull request Aug 29, 2022
WayneFerrao pushed a commit to WayneFerrao/FluidFramework that referenced this pull request Aug 31, 2022
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution.
- Ability to add a user-specified category to tests, for selective execution.

Specifically for memory tests:
- Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones.
- Print the computed statistics to the output file when using the custom mocha reporter.
- Unit tests for function that computes statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants