New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve benchmark tool #11661
Merged
Merged
Improve benchmark tool #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-cai-microsoft
approved these changes
Aug 25, 2022
|
This commit is queued for merging with the |
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Aug 26, 2022
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution. - Ability to add a user-specified category to tests, for selective execution. Specifically for memory tests: - Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones. - Print the computed statistics to the output file when using the custom mocha reporter. - Unit tests for function that computes statistics.
Merged
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution. - Ability to add a user-specified category to tests, for selective execution. Specifically for memory tests: - Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones. - Print the computed statistics to the output file when using the custom mocha reporter. - Unit tests for function that computes statistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some improvements to the benchmark tool:
benchmark()andbenchmarkMemory()now automatically tag tests with@ExecutionTimeor@MemoryUsage, respectively, to allow for selective execution.Specifically for memory tests: