Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing of memory performance test results #11665

Merged
merged 25 commits into from Aug 31, 2022

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Aug 25, 2022

Description

Follow-up to #11622, for memory tests. Updates tools and pipelines to execute our memory usage tests and report results to Kusto.

Any relevant logs or outputs

A few successful pipeline runs here and here.

Results in Kusto

Execution time tests

image

Memory tests

image

Other information or known dependencies

Depends on #11661 .

AB 957

@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: sharedstring dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Aug 25, 2022
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Aug 26, 2022
@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Aug 30, 2022
@alexvy86 alexvy86 marked this pull request as ready for review August 30, 2022 17:42
@alexvy86 alexvy86 requested review from msfluid-bot and a team as code owners August 30, 2022 17:42
@alexvy86
Copy link
Contributor Author

@anthony-murphy , @curtisman , could you take a look at this one when you have a chance?

@@ -32,7 +31,7 @@ parameters:

- name: poolBuild
type: object
default: Small
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the switch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the time it takes for the repo to build (npm run ci:build) in Small vs Large is extremely different, 33m vs 5m. If we're fine letting this pipeline take much longer to run, we can change it back to Small, but I thought Large would be better. If we eventually move to a model where only 1 pipeline does the build and the rest work on its artifacts, this decision will go away 😄 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... we are still rebuilding in the pipeline. That make more sense.

We should switch back to small once (or if) we stop rebuilding.

@alexvy86 alexvy86 merged commit 3953e80 into microsoft:main Aug 31, 2022
@alexvy86 alexvy86 deleted the memory-test-processing branch August 31, 2022 23:36
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dds: sharedstring area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants