Update CI pipeline to support installing build-tools from npm #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
commented
Aug 25, 2022
build-tools/packages/build-cli/src/commands/generate/buildVersion.ts
Outdated
Show resolved
Hide resolved
curtisman
approved these changes
Aug 26, 2022
| @@ -21,6 +21,10 @@ parameters: | |||
| - default | |||
| - skip | |||
| - force | |||
| - name: buildToolsVersionToInstall | |||
| displayName: Fluid build tools version (default = installs version in repo) | |||
There was a problem hiding this comment.
should it default to not repo? the repo version does add non-trivial time to the pipeline.
There was a problem hiding this comment.
Once the build tools are baked, I'll update the default for main. In lts it'll default to npm, but main for now will use the in-repo version.
|
This commit is queued for merging with the |
tylerbutler
added a commit
that referenced
this pull request
Aug 27, 2022
This is the same as #11670 with some minor adjustments for the lts branch. Most notably, it defaults to the latest npm version of the build tools instead of the in-repo version.
alexvy86
reviewed
Aug 29, 2022
| npm ci | ||
| popd | ||
|
|
||
| - ${{ if ne(parameters.buildToolsVersionToInstall, 'repo') }}: |
There was a problem hiding this comment.
Curious if we use an if-equal above and an independent if-not-equal here over an else for some reason?
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
tylerbutler
added a commit
that referenced
this pull request
Aug 31, 2022
This is the same as #11670 with some minor adjustments for the lts branch. Most notably, it defaults to the latest npm version of the build tools instead of the in-repo version.
tylerbutler
added a commit
that referenced
this pull request
Oct 14, 2022
The previous change in #11670 was incomplete. It did not properly pass through the build tools location from the ADO UI all the way to the right places. This change corrects that. I tested by manually running a build with the "next" value for the build tools source, and verified that the prerelease (tagged `@next`) version was installed.
sharptrip
pushed a commit
to sharptrip/FluidFramework
that referenced
this pull request
Oct 17, 2022
The previous change in microsoft#11670 was incomplete. It did not properly pass through the build tools location from the ADO UI all the way to the right places. This change corrects that. I tested by manually running a build with the "next" value for the build tools source, and verified that the prerelease (tagged `@next`) version was installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use our homegrown build-tools to do some tasks in our CI pipelines. It's helpful to be able to install the local in-repo version of the tools in most cases, but sometimes we want to install from npm instead. This change enables us to control the version of the build tools that are installed via a pipeline variable that's set when the pipeline is run.