Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sequence merge-tree): more robustly handle rebasing interval ops #11672

Merged
merged 12 commits into from Aug 31, 2022
Merged

fix(sequence merge-tree): more robustly handle rebasing interval ops #11672

merged 12 commits into from Aug 31, 2022

Conversation

connorskees
Copy link
Member

Description

More robustly implements interval rebasing and adds relevant test cases.

ado 1435

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring public api change Changes to a public API base: main PRs targeted against main branch labels Aug 25, 2022
@connorskees connorskees marked this pull request as ready for review August 25, 2022 17:00
@connorskees connorskees requested a review from a team as a code owner August 25, 2022 17:00
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 25, 2022 •
edited

⯅ @fluid-example/bundle-size-tests: +1013 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 392.31 KB 392.81 KB ⯅ +511 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 191.79 KB 191.79 KB ■ No change
loader.js 151.12 KB 151.12 KB ■ No change
map.js 42.63 KB 42.63 KB ■ No change
matrix.js 131.63 KB 131.62 KB ⯆ -6 Bytes
odspDriver.js 150.23 KB 150.23 KB ■ No change
odspPrefetchSnapshot.js 38.39 KB 38.39 KB ■ No change
sharedString.js 152.42 KB 152.92 KB ⯅ +508 Bytes
Total Size 1.25 MB 1.25 MB ⯅ +1013 Bytes

Baseline commit: 8a4f5c9

Generated by 🚫 dangerJS against 976e89c

Abe27342
Abe27342 reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@Abe27342 Abe27342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall strategy looks solid. A few pieces of feedback for improvement.

packages/dds/merge-tree/src/client.ts Outdated Show resolved Hide resolved
packages/dds/sequence/src/intervalCollection.ts Show resolved Hide resolved
packages/dds/sequence/src/intervalCollection.ts Show resolved Hide resolved
packages/dds/sequence/src/intervalCollection.ts Outdated Show resolved Hide resolved
packages/dds/sequence/src/test/intervalRebasing.spec.ts Outdated Show resolved Hide resolved
packages/dds/sequence/src/test/intervalRebasing.spec.ts Outdated Show resolved Hide resolved
packages/dds/sequence/src/test/intervalRebasing.spec.ts Outdated Show resolved Hide resolved
packages/dds/sequence/src/test/intervalUtils.ts Show resolved Hide resolved
@connorskees connorskees merged commit 179502b into microsoft:main Aug 31, 2022
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abe27342 Abe27342 Abe27342 approved these changes

Assignees
No one assigned
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@connorskees @msfluid-bot @Abe27342