More EditManager testing #11680
Merged
More EditManager testing #11680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
alex-pardes
approved these changes
Aug 25, 2022
Comment on lines
+689
to
+691
| const localIntentions = ([] as number[]).concat( | ||
| ...client.localChanges.map((c) => c.change.intentions), | ||
| ); |
There was a problem hiding this comment.
Looks like in ES2019 there is a flatMap method on Array. Would be nice if we put something like that in a util file.
Co-authored-by: alex-pardes <105307164+alex-pardes@users.noreply.github.com>
|
This commit is queued for merging with the |
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
* Verify returned deltas * Tweaks * Check anchor intentions * Move anchor state out of TestChangeRebaser * Apply suggestions from code review Co-authored-by: alex-pardes <105307164+alex-pardes@users.noreply.github.com> * Comment on asDelta * Remove dependence on EditManager for test input Co-authored-by: alex-pardes <105307164+alex-pardes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More thorough testing of
EditManager:EditManagerwhen callingaddLocalChangeandaddSequencedChange.Other changes:
TestChangeRebasercode to make it less stateful