Update logging in build-tools and add commit date support in GitRepo #11692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public api change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @returns The commit date of the ref. | ||
| */ | ||
| public async getCommitDate(gitRef: string) { | ||
| const result = (await this.exec(`show -s --format=%cI "${gitRef}"`, `get commit date ${gitRef}`)).trim(); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
There was a problem hiding this comment.
This is pretty cool of Github 😄
tylerbutler
force-pushed
the
cli/part-2
branch
from
c0e6824
to
a3fd63e
Compare
tylerbutler
force-pushed
the
cli/part-2
branch
from
a3fd63e
to
d002f6f
Compare
alexvy86
approved these changes
Aug 29, 2022
|
Thanks for the review, @alexvy86 ! |
|
This commit is queued for merging with the |
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
…icrosoft#11692) This change primarily updates the legacy build-tools to better use a unified logging infrastructure that was added in an earlier PR. It also adds the ability to get a commit date from a git ref, which will be used in an upcoming PR to build release reports.
tylerbutler
added a commit
that referenced
this pull request
Aug 31, 2022
Follow up to #11692. Adds APIs for: - Generating branch names. - Creating release and dep bump branches. - Checking npm for package updates. - Checking if a particular version has been released. - Getting all versions and their dates based on the git tag. - Sorting versions based on date and semver version. These APIs will be used heavily in the `release` and `release report` commands (future changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change primarily updates the legacy build-tools to better use a unified logging infrastructure that was added in an earlier PR. It also adds the ability to get a commit date from a git ref, which will be used in an upcoming PR to build release reports.