Fix and add tests for the buildVersion CLI #11698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
commented
Aug 26, 2022
build-tools/packages/build-cli/src/commands/generate/buildVersion.ts
Outdated
Show resolved
Hide resolved
tylerbutler
changed the title
curtisman
approved these changes
Aug 26, 2022
|
This commit is queued for merging with the |
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Aug 26, 2022
This change adds tests for the generate buildVersion CLI command and updates the code so that it reads environment variables correctly.
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
This change adds tests for the generate buildVersion CLI command and updates the code so that it reads environment variables correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
generate buildVersionCLI command and updates the code so that it reads environment variables correctly. oclif boolean flags do not get set from env variables, despite what the types indicate.