Remove Quorum DDS optimization #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
alexvy86
reviewed
Aug 29, 2022
scottn12
approved these changes
Aug 30, 2022
|
This commit is queued for merging with the |
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's reasonable to assume that the client submitting a "set" op would accept the op. However, using this as an optimization correctly would require the sender to recognize this unique state they are in (not quite pending because they might lose the "set" race, but also not in rest state because other clients might perceive them as in "accept" state).
Adding the states and inspection API surface to handle this in-between state is probably more complexity than the optimization is worth, so I'm electing to remove it. Now all clients will react to incoming "set" ops the same way and be expected to explicitly "accept" them.