build-tools: Add several APIs to build-cli #11705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public api change
tylerbutler
commented
Aug 27, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (releaseGroupOrPackage instanceof MonoRepo) { | ||
| workingDir = releaseGroupOrPackage.repoPath; | ||
| cmd = `npx lerna version ${translatedVersion.version} --no-push --no-git-tag-version -y && npm run build:genver`; |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
| cmd = `npx lerna version ${translatedVersion.version} --no-push --no-git-tag-version -y && npm run build:genver`; | ||
| } else { | ||
| workingDir = releaseGroupOrPackage.directory; | ||
| cmd = `npm version ${translatedVersion.version}`; |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
tylerbutler
force-pushed
the
cli/part-3
branch
from
f1ab312
to
969c4ee
Compare
tylerbutler
force-pushed
the
cli/part-3
branch
from
969c4ee
to
7b3d3fd
Compare
tylerbutler
commented
Aug 30, 2022
Josmithr
approved these changes
Aug 31, 2022
build-tools/packages/build-cli/test/commands/generate/buildVersion.test.ts
Outdated
Show resolved
Hide resolved
tylerbutler
commented
Aug 31, 2022
Josmithr
approved these changes
Aug 31, 2022
|
This commit is queued for merging with the |
tylerbutler
added a commit
that referenced
this pull request
Sep 6, 2022
…state machine to govern logic (#11706) Follow up to #11705. - Adds an abstract base command class for commands that use state machines. This base command contains the scaffolding for commands that have internal state machines, including some logging for each state transition and handling the Init and Failed states. - Adds various interfaces and types for working with the state machine. - Adds the Fluid Unified Release Process finite state machine, which is used by the `release` command. This PR also implements the `release` command, which is used to ensure that a release branch is in good condition, then walks the user through the release. ## The release process and state machine The release process itself is described by a state machine. The basic flow of the command is: - The command starts and oclif (our CLI infrastructure) parses flags and arguments, validates them, etc. - The command's _run_ method is called, which calls an internal _stateLoop_ function. - That function loops through the machine states, passing each state to the command's state handler function. - The state handler handles the states it knows about, and if it doesn't handle the state, it passes it to its parent's state handler. Thus, the parent classes are relevant to the overall implementation of the state handling. In previous iterations there was a deeper class hierarchy, but now there's just one base abstract state machine command and the release command that inherits from it. Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11692.
Adds APIs for:
These APIs will be used heavily in the
releaseandrelease reportcommands (future PRs).