Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package publishing pipeline for non-lerna packages #11707

Merged
merged 9 commits into from Aug 29, 2022
Merged

Fix package publishing pipeline for non-lerna packages #11707

merged 9 commits into from Aug 29, 2022

Conversation

jenn-le
Copy link
Contributor

@jenn-le jenn-le commented Aug 27, 2022

The publish package pipeline currently fails silently when publishing packages that don't use lerna because it is assumed that packagePublishOrder is generated which is not true in this case.

@jenn-le jenn-le requested a review from a team as a code owner August 27, 2022 00:43
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Aug 27, 2022
@jenn-le jenn-le changed the title Check that packagePublishOrder exists Fix package publishing pipeline for non-lerna packages Aug 27, 2022
alexvy86
alexvy86 previously approved these changes Aug 27, 2022
View reviewed changes
tools/pipelines/templates/include-publish-npm-package-steps.yml Outdated Show resolved Hide resolved
@alexvy86
Copy link
Contributor

Actually, maybe take back my approval...? The test pipeline run seems to not have published anything... the logs of that step just printed the tag name. We might need a bit of extra debugging in the script to see what happened.

@alexvy86 alexvy86 self-requested a review August 27, 2022 02:29
@alexvy86 alexvy86 dismissed their stale review August 27, 2022 02:29

Need to check why the pipeline didn't publish anything

@jenn-le
Copy link
Contributor Author

jenn-le commented Aug 27, 2022

Actually, maybe take back my approval...? The test pipeline run seems to not have published anything... the logs of that step just printed the tag name. We might need a bit of extra debugging in the script to see what happened.

Got it working! Here's the successful run: https://dev.azure.com/fluidframework/internal/_build/results?buildId=89095&view=logs&j=88a4f9f3-7925-540d-9db1-365e924a72d7&t=99b824bb-90f8-50be-43a9-46dc96229166

@jenn-le jenn-le merged commit df37cbd into main Aug 29, 2022
@jenn-le jenn-le deleted the test/fix-package-publish branch August 29, 2022 15:16
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

WayneFerrao pushed a commit to WayneFerrao/FluidFramework that referenced this pull request Aug 31, 2022
@jenn-le @WayneFerrao
Fix package publishing pipeline for non-lerna packages (microsoft#11707)
1808785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvy86 alexvy86 alexvy86 approved these changes

Assignees
No one assigned
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenn-le @alexvy86