New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF.com containers docs updates #11708
FF.com containers docs updates #11708
Conversation
| @@ -107,72 +114,48 @@ const { container, services } = | |||
| await client.getContainer(/*container id*/, schema); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using container IDs in our telemetry to represent instance of the container runtime. What we call here "container ID" is really "docId" in our telemetry. Clients will often use our telemetry to log/observe errors so this will certainly create confusion. At the very least we likely need more explicit clarification on telemetry/logging docs.
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
This commit is queued for merging with the |
AB#1238
Further clarifications around containers, what they achieve, implications around their lifecycle etc. All in the context of "build with fluid".