Start running build-cli tests in CI #11713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josmithr
approved these changes
Aug 29, 2022
| @@ -38,7 +38,8 @@ | |||
| "lint:fix": "npm run prettier:fix && npm run eslint:fix", | |||
| "prettier": "prettier --check .", | |||
| "prettier:fix": "prettier --write .", | |||
| "test": "mocha --forbid-only \"test/**/*.test.ts\" --unhandled-rejections=strict", | |||
| "test": "npm run test:mocha", | |||
| "test:mocha": "mocha --forbid-only \"test/**/*.test.ts\" --unhandled-rejections=strict", | |||
There was a problem hiding this comment.
Should we move the declared params here into a mocha config file instead?
There was a problem hiding this comment.
I agree, but this seems to be a common pattern in the repo, so I'll leave it as-is for consistency. Here's an example from the map package:
|
This commit is queued for merging with the |
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just enables the mocha tests for the build-cli project to run in CI.