New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation: Main Next Integrate #11721
Merged
sonalivdeshpande
merged 8 commits into
next
from
main-next-6243a439ab0e7153ae574b947ab7004bc3001d7f
Aug 30, 2022
Merged
Automation: Main Next Integrate #11721
sonalivdeshpande
merged 8 commits into
next
from
main-next-6243a439ab0e7153ae574b947ab7004bc3001d7f
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New npm scripts to run perf-tests * New tool to process perf test output files * Pipeline to run perf benchmarks and send metrics to Kusto * Update dependencies on @fluid-tools/benchmark to 0.42.0
* Attempt to address AB 357
- benchmark() and benchmarkMemory() now automatically tag tests with @ExecutionTime or @MemoryUsage, respectively, to allow for selective execution. - Ability to add a user-specified category to tests, for selective execution. Specifically for memory tests: - Ability to define a percentage of samples to use when computing statistics. If not set to 1 (100%), the lowest and highest samples are dropped, and statistics are only computed from the remaining ones. - Print the computed statistics to the output file when using the custom mocha reporter. - Unit tests for function that computes statistics.
This change adds tests for the generate buildVersion CLI command and updates the code so that it reads environment variables correctly.
* Fix gc dataStore no duplicate routes test
|
@NicholasCouri it looks like your changes have caused a merge conflict, I don't have the context to exactly resolve the conflicts, granted it looks somewhat straight forward. |
|
Status: looking at the build failure. |
⯅ @fluid-example/bundle-size-tests: +14.87 KB
Baseline commit: 6243a43 |
NicholasCouri
approved these changes
Aug 30, 2022
tyler-cai-microsoft
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tylerbutler
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: build
Build related issues
area: dds
Issues related to distributed data structures
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: next
PRs targeted against next branch
community-contribution
dependencies
Pull requests that update a dependency file
do-not-squash-merge
main-next-integrate
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main-next integrate PR
The aim of this pull request is to sync main and next branch. The expectation from the assignee is as follows:
For more information about how to resolve merge conflicts and CI failures, visit [this wiki page]
(https://github.com/microsoft/FluidFramework/wiki/Main-next-Automation).