Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TaskManager DDS] Reorganize test file #11727

Merged
merged 1 commit into from Aug 31, 2022

Conversation

scottn12
Copy link
Contributor

This PR reorganizes the UT file. This is done is a separate PR to reduce the number of changes in #11649.

@scottn12 scottn12 requested a review from a team as a code owner August 30, 2022 19:50
@github-actions github-actions bot added area: dds Issues related to distributed data structures base: next PRs targeted against next branch labels Aug 30, 2022
Copy link
Contributor

@ChumpChief ChumpChief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you for doing this!

@ChumpChief
Copy link
Contributor

Rerunning failed jobs as they look unrelated.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +14.87 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 391.83 KB 392.81 KB +1011 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.3 KB 195.53 KB +4.23 KB
loader.js 151.12 KB 151.06 KB -57 Bytes
map.js 42.63 KB 47.38 KB +4.75 KB
matrix.js 131.63 KB 134.98 KB +3.35 KB
odspDriver.js 150.23 KB 150.11 KB -127 Bytes
odspPrefetchSnapshot.js 38.39 KB 38.35 KB -41 Bytes
sharedString.js 152.42 KB 154.2 KB +1.77 KB
Total Size 1.25 MB 1.27 MB +14.87 KB

Baseline commit: 6243a43

Generated by 🚫 dangerJS against c8c4ccb

@msftbot
Copy link
Contributor

msftbot bot commented Aug 31, 2022

Hello @scottn12!

Because this pull request has the msftbot: merge-next label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@msftbot msftbot bot merged commit 29e99b3 into microsoft:next Aug 31, 2022
@scottn12 scottn12 deleted the reorganizeTestFile branch August 31, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures base: next PRs targeted against next branch msftbot: merge-next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants