New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website code to use the new api-markdown-documenter package for generating API docs
#11754
Update website code to use the new api-markdown-documenter package for generating API docs
#11754
Conversation
…ithr/FluidFramework into use-api-markdown-documenter
|
Links to the root "Packages" document are broken. Fix PR is here: #11803 Update: resolved |
__pr-review/aqueduct-after.md
Outdated
| @@ -0,0 +1,623 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these files before merging :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. I'm still a bit confused why frontmatter is something that has to be done outside of APi documenter. It seems reasonable to expect API documenter to support adding front-matter to output. Creating the front-matter also seems more complex that it should be. Maybe because it's JS? Anything non-trivial I prefer in TS for safety and maintainability. In particular, front matter should be typed, IMO.
Yeah, I had been debating whether or not it made sense to include a hook for that in the library. My initial thinking was that it was too use-case specific, but now I think my opinion has changed. Adding a hook for this is probably reasonable. I'll file a task to do that. Regarding the complexity, I agree. I'm also not sure were really using most of the information we gather there. I want to do a follow-up pass to see what data we actually need so we can reduce both the logic complexity, and the amount of front-matter we append to each document. |
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
This commit is queued for merging with the |
Summary
This PR updates the website (/docs) build to use
@fluid-tools/api-markdown-documenterto generate API documentation from the.api.jsonfiles generated by API-Extractor.Formatting
This version of the package attempts to maintain parity with the current rendering as much as is reasonable. The only exceptions are changes where I felt the new behavior was superior and maintaining parity would require more work than keeping the better behavior. There are also a handful of other minor improvements that were easy enough to make, that I put them in v1. Changes include:
Modifierscolumn - we now only render this column in tables if any entry has a value to display).Return Typecolumn to function/method tablesTypecolumn to variable/parameter tablesSignature)Related changes
This PR also fixes links and comment formatting issues in a number of places. Some are fixes related to the new infra, but others are simply issues I discovered while auditing formatting changes.