Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Message Types. Remove unused process() argument #11765

Closed
wants to merge 1 commit into from

Conversation

vladsud
Copy link
Contributor

@vladsud vladsud commented Aug 31, 2022

No description provided.

@vladsud vladsud requested review from a team as code owners August 31, 2022 22:58
@github-actions github-actions bot added area: examples Changes that focus on our examples area: loader Loader related issues area: server Server related issues (routerlicious) public api change Changes to a public API base: main PRs targeted against main branch labels Aug 31, 2022
@@ -16,8 +16,6 @@ export enum MessageType {
// Proposes a new consensus value
Propose = "propose",

// Message used to reject a pending proposal
Reject = "reject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to go into next along with all the typeValidation stuff

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -11 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 392.81 KB 392.81 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.79 KB 191.79 KB No change
loader.js 151.71 KB 151.7 KB -11 Bytes
map.js 42.63 KB 42.63 KB No change
matrix.js 131.62 KB 131.62 KB No change
odspDriver.js 150.23 KB 150.23 KB No change
odspPrefetchSnapshot.js 38.39 KB 38.39 KB No change
sharedString.js 152.92 KB 152.92 KB No change
Total Size 1.25 MB 1.25 MB -11 Bytes

Baseline commit: 2d89900

Generated by 🚫 dangerJS against ec00b51

@vladsud
Copy link
Contributor Author

vladsud commented Sep 2, 2022

Closing in favor of #11805 (next branch)

@vladsud vladsud closed this Sep 2, 2022
@vladsud vladsud deleted the opProcessing1 branch September 19, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples area: loader Loader related issues area: server Server related issues (routerlicious) base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants