FIx noops #11768
Closed
FIx noops #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
GaryWilber
reviewed
Sep 1, 2022
| if (this.currentlyProcessingOps && this.preventConcurrentOpSend) { | ||
| this.close(new UsageError("Making changes to data model is disallowed while processing ops.")); | ||
| } | ||
| const messagePartial: Omit<IDocumentMessage, "clientSequenceNumber"> = { | ||
| contents: JSON.stringify(contents), |
There was a problem hiding this comment.
Could we update the IDocumentMessage contents property to be a string (or maybe string | undefined)?
There was a problem hiding this comment.
It will be a big (but necessary change). I'll track it as separate item.
|
Closing in favor of PR #11790 - for some reason this PR does not "see" latest commits in the branch (it's same branch!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting noop logic out of https://github.com/microsoft/FluidFramework/pull/11262/files
Through code review, I've noticed that we send content="null" for non-immediate noops, but service expects content === null to differentiate immediate vs. non-immediate noops. In other words, non-immediate noops are considered to be immediate noops by service and they are never coalesced! I've noticed it only because I worked (not part of this PR) to move content strigification out of loader layer into runtime.
While we can fix it on service side (and leave client as is), I really do not like current design and special types based on type of content. So splitting noops into "accept" (formerly - immediate noops) and noops (non-immediate). Once this change propagates through the system, service can