Automation: Main Next Integrate #11769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
#11686) `@fluidframework/counter` is now promoted more directly on our website, including its API docs. This PR is aimed at cleaning up those docs for public consumption. Mostly simple typo fixes and capitalization/punctuation improvements. But it also moves `SharedCounter`'s summary docs away from using embedded Markdown syntax (which is not supported) toward using `@example` tag syntax for its flow examples.
Fix AB 1633 Summary Upload Error
…ors (Some batching improvements part 2) (#11579) This used to be driven by two asserts (0x170 and 0x16f) but the change makes the situation more explicit by closing the container and not relying on the exception handler of who's using the PendingStateManager. And also adds more information to the error.
|
"Actively working on it" |
|
Conflict is in packages/runtime/container-runtime/src/test/pendingStateManager.spec.ts . Looks like @andre4i would be the best contact for resolving it. |
github-actions
bot
added
area: build
|
Also, the failed |
|
Working on the test failures. Will update the branch accordingly. |
sonalivdeshpande
approved these changes
Sep 1, 2022
|
PR checks passed. merging it. thanks @CraigMacomber, @andre4i, @alexvy86!! |
sonalivdeshpande
deleted the
main-next-ea3f1188f124a34b98e8e8658bb7f1c9623137fb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main-next integrate PR
The aim of this pull request is to sync main and next branch. The expectation from the assignee is as follows:
For more information about how to resolve merge conflicts and CI failures, visit [this wiki page]
(https://github.com/microsoft/FluidFramework/wiki/Main-next-Automation).