Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bump] client: 1.2.5 => 1.2.6 (patch) #11774

Merged
merged 1 commit into from Sep 1, 2022

Conversation

tylerbutler
Copy link
Member

Post-release patch bump of client.

Post-release patch bump of client.
@tylerbutler tylerbutler marked this pull request as ready for review September 1, 2022 00:51
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners September 1, 2022 00:51
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: release PRs targeted against a release branch labels Sep 1, 2022
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI a160927

Generated by 🚫 dangerJS against 4db9f75

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiosity: we just update lerna.json, run some command, and it takes care of the updates, right?

@tylerbutler
Copy link
Member Author

@alexvy86 It's a little more complicated because of our various version schemes and because we release individual packages too. But we do use lerna version for a lot of the heavy lifting for release groups. The core code is here in my pending PR (#11706):

case "DoReleaseGroupBump": {
const rgRepo = isReleaseGroup(this.releaseGroup)
? context.repo.releaseGroups.get(this.releaseGroup)!
: context.fullPackageMap.get(this.releaseGroup!)!;
const scheme = detectVersionScheme(this.releaseVersion!);
const newVersion = bumpVersionScheme(this.releaseVersion, this.bumpType!, scheme);
const packages = rgRepo instanceof MonoRepo ? rgRepo.packages : [rgRepo];
this.log(
`Version ${this.releaseVersion} of ${
this.releaseGroup
} already released, so we can bump to ${newVersion} (${chalk.blue(
this.bumpType!,
)} bump)!`,
);
const bumpResults = await bumpReleaseGroup(context, this.bumpType!, rgRepo, scheme);
this.verbose(`Raw bump results:`);
this.verbose(bumpResults);
if (this.shouldInstall && !(await FluidRepo.ensureInstalled(packages, false))) {
this.errorLog("Install failed.");
this.machine.action("failure");
}
this.machine.action("success");
break;
}

@tylerbutler tylerbutler merged commit 1f3e07d into release/1.2 Sep 1, 2022
@tylerbutler tylerbutler deleted the bump_client_patch_1.2.6 branch September 1, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: release PRs targeted against a release branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants