Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build-tools] Correct release branch names #11775

Merged
merged 2 commits into from Sep 1, 2022
Merged

[build-tools] Correct release branch names #11775

merged 2 commits into from Sep 1, 2022

Conversation

tylerbutler
Copy link
Member

The release branch name generation function didn't handle older releases of client that don't use the internal version scheme.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Sep 1, 2022
@tylerbutler tylerbutler marked this pull request as ready for review September 1, 2022 01:17
scottn12
scottn12 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@scottn12 scottn12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tylerbutler
Copy link
Member Author

Thanks @scottn12!

@tylerbutler tylerbutler merged commit 98966c2 into microsoft:main Sep 1, 2022
@tylerbutler tylerbutler deleted the cli/fix-rel-branch-name branch September 1, 2022 17:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottn12 scottn12 scottn12 approved these changes

@Josmithr Josmithr Awaiting requested review from Josmithr

@sonalivdeshpande sonalivdeshpande Awaiting requested review from sonalivdeshpande

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerbutler @scottn12