MergeTree: Support Local References in TrackingGroups #11778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Abe27342
reviewed
Sep 1, 2022
github-actions
bot
added
area: dds: sharedstring
area: framework
Abe27342
reviewed
Sep 1, 2022
Abe27342
approved these changes
Sep 6, 2022
…to lr-tracking-groups
anthony-murphy
commented
Sep 6, 2022
…to lr-tracking-groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change add support for LocalReferencePositions to TrackingGroups and their underlying sorted segment set. This will allow tracking removed segments with LocalReferencePositions for undo redo, which will be both more accurate and result in less tree fragmentation than the existing method of maintaining and tracking removed segments in the tree itself.
Other information or known dependencies
AB#45
AB#147
AB#151