Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup waitIntervalCollection and getTextRangeWithPlaceholders #11789

Closed
wants to merge 2 commits into from
Closed

Cleanup waitIntervalCollection and getTextRangeWithPlaceholders #11789

wants to merge 2 commits into from

Conversation

Abe27342
Copy link
Contributor

@Abe27342 Abe27342 commented Sep 1, 2022

Description

These APIs were deprecated in main in previous PRs and are straightforward to migrate off of, but were never removed in next. This remedies that.

@Abe27342 Abe27342 requested review from msfluid-bot and a team as code owners September 1, 2022 22:06
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring breaking change This PR or issue would introduce a breaking change public api change Changes to a public API base: next PRs targeted against next branch labels Sep 1, 2022
@Abe27342 Abe27342 requested a review from a team as a code owner September 1, 2022 22:24
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Sep 1, 2022
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI ea3f118

Generated by 🚫 dangerJS against 1358d49

@Abe27342
Copy link
Contributor Author

Abe27342 commented Sep 7, 2022

just doing this in #11788

@Abe27342 Abe27342 closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

@anthony-murphy anthony-murphy Awaiting requested review from anthony-murphy

Assignees
No one assigned
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: next PRs targeted against next branch breaking change This PR or issue would introduce a breaking change public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abe27342 @msfluid-bot