New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Noops #11790
Merged
Merged
Fix Noops #11790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
⯅ @fluid-example/bundle-size-tests: +97 Bytes
Baseline commit: ca9df05 |
andre4i
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is ok but it needs to have the package.json breaking stuff and also in the next branch
packages/test/test-end-to-end-tests/src/test/detachedContainerTests.spec.ts
Show resolved
Hide resolved
andre4i
approved these changes
Sep 2, 2022
|
This commit is queued for merging with the |
vladsud
added a commit
that referenced
this pull request
Sep 2, 2022
Introducing new type of messages - "accept", that will be used to replace immediate noops. This is integral part of PR #11790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: loader
Loader related issues
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting noop logic out of https://github.com/microsoft/FluidFramework/pull/11262/files
Through code review, I've noticed that we send content="null" for non-immediate noops, but service expects content === null to differentiate immediate vs. non-immediate noops. In other words, non-immediate noops are considered to be immediate noops by service and they are never coalesced! I've noticed it only because I worked (not part of this PR) to move content strigification out of loader layer into runtime.
While we can fix it on service side (and leave client as is), I really do not like current design and special types based on type of content. So splitting noops into "accept" (formerly - immediate noops) and noops (non-immediate). Once this change propagates through the system, service can