Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix DDS memory profiling tests #11796

Merged
merged 10 commits into from Sep 6, 2022
Merged

Matrix DDS memory profiling tests #11796

merged 10 commits into from Sep 6, 2022

Conversation

ghoshkaj
Copy link
Contributor

@ghoshkaj ghoshkaj commented Sep 2, 2022 •
edited

Create test to benchmark Matrix DDS memory footprint.

@github-actions github-actions bot added area: dds Issues related to distributed data structures base: main PRs targeted against main branch labels Sep 2, 2022
alexvy86
alexvy86 requested changes Sep 2, 2022
View reviewed changes
packages/dds/matrix/tsconfig.json Outdated Show resolved Hide resolved
packages/dds/matrix/src/test/tsconfig.json Outdated Show resolved Hide resolved
packages/dds/matrix/src/test/memory/.mocharc.js Outdated Show resolved Hide resolved
packages/dds/matrix/package.json Outdated Show resolved Hide resolved
@ghoshkaj ghoshkaj marked this pull request as ready for review September 2, 2022 21:38
@ghoshkaj ghoshkaj requested review from msfluid-bot and a team as code owners September 2, 2022 21:38
alexvy86
alexvy86 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one thing, can you add a screenshot of the output of the tests? I'd like to see how the numbers look right now.

@ghoshkaj
Copy link
Contributor Author

ghoshkaj commented Sep 6, 2022

@alexvy86 here is a screeshot of the benchmark now!

image

@alexvy86
Copy link
Contributor

alexvy86 commented Sep 6, 2022

@ghoshkaj thanks. Good to merge 👍 .

@ghoshkaj ghoshkaj merged commit d848194 into microsoft:main Sep 6, 2022
@ghoshkaj ghoshkaj deleted the matrix-dds-memory-profiling-tool branch September 6, 2022 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvy86 alexvy86 alexvy86 approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghoshkaj @alexvy86