New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default documentation rendering behaviors #11817
Improve default documentation rendering behaviors #11817
Conversation
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
This commit is queued for merging with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧵
Accidentally checked in with #11817
"V1" of the library was configured with rendering policies to (mostly) match our existing website rendering. I peeled most of these changes out into a separate PR to avoid conflating the introduction of new infrastructure with rendering improvements. It additionally made before/after comparisons much easier to make.
This PR introduces the rendering improvements I would have otherwise included in the initial package version. It also includes a couple of "fixes" to address issues I discovered later.
Improvements include:
Alertrendering for deprecation notices, etc. (this was lacking in the initial implementation as an oversight).DEPRECATEDalert column/cells to table containing deprecated items, to make deprecation more immediately evident.Package/Namespaceas follows: (Class,Function,Interface,Namespace,Variable,Type) -> (Interface,Class,Type,Function,Variable,Namespace).Interfaceitems above other item kinds, as these are generally the most semantically important.Class/Interfacemembers@sealedand@virtualto list of tags added to "Modifiers" table cells by default.@seecomment blocks (added to the bottom of any parent section as appropriate).Also update some related documentation.
Notes:
MarkdownEmitterimplementation has been pre-fixed to correctly handle alert rendering, and fix note-box rendering, but these changes will not be reflected in the site's content until the new package version has been published and adopted, which will occur in a separate PR.