Tree: Misc schema related cleanup and fix #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
jenn-le
approved these changes
Sep 6, 2022
| @@ -29,64 +29,40 @@ const jsonTypes: Set<TreeSchemaIdentifier> = new Set(); | |||
|
|
|||
| const json: NamedTreeSchema[] = []; | |||
|
|
|||
| export const jsonObject: NamedTreeSchema = { | |||
| export const jsonObject: NamedTreeSchema = namedTreeSchema({ | |||
There was a problem hiding this comment.
nit: We probably don't need the type annotation anymore.
There was a problem hiding this comment.
I considered removing them. Since this schema kind of serves as an example, I left the overly explicit types think they might make it slightly easier to understand and navigate to the relevant types. Could really go either way though.
There was a problem hiding this comment.
Sounds good, I don't have a strong opinion either way.
Co-authored-by: Jenn <jennle@microsoft.com>
|
This commit is queued for merging with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc cleanups and fix from #11589 (and some extra cleanup to the Json domain schema).
Fix is that StoredSchemaRepository did not actually use the schema data passes into it.