Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize some website dependencies and load from CDN #11847

Merged
merged 6 commits into from Sep 8, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Sep 7, 2022

This change loads the jquery and bootstrap JS from CDN rather than bundling them with our scripts. This addressed the Guardian failures. We should still fix #9316 regardless of this change.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Sep 7, 2022
@tylerbutler tylerbutler marked this pull request as ready for review September 7, 2022 20:17
@tylerbutler tylerbutler requested a review from a team as a code owner September 7, 2022 20:17
@tylerbutler tylerbutler changed the title Extend expiry of the baselines in our docs build Externalize some website dependencies and load from CDN Sep 8, 2022
Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:583) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.eot? (HTTP 503)
- (1:1031) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.svg (HTTP 503)
- (1:1272) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot? (HTTP 503)
- (1:1740) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.svg (HTTP 503)
- (1:1982) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.eot? (HTTP 503)
- (1:2427) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.svg (HTTP 503)
- (1:3130) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.svg (HTTP 503)
- (1:3286) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot (HTTP 503)
- (1:3811) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.svg (HTTP 503)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer-interface
- (888:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (899:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (907:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (953:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer-interface/
- (888:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (899:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (907:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (953:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)


Stats:
  125866 links
    1303 destination URLs
       1 URLs ignored
       8 warnings
       9 errors


@tylerbutler tylerbutler merged commit c490d23 into microsoft:main Sep 8, 2022
@tylerbutler tylerbutler deleted the baselines branch September 8, 2022 01:24
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace jquery use in website
2 participants