Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursor benchmarks #11849

Merged
merged 16 commits into from Sep 8, 2022
Merged

Add cursor benchmarks #11849

merged 16 commits into from Sep 8, 2022

Conversation

jenn-le
Copy link
Contributor

@jenn-le jenn-le commented Sep 7, 2022

This adds a sum benchmark that is being split out from this PR: #11610. Also adds a perimeter benchmark for measuring access to known fields rather than enumeration.

@github-actions github-actions bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures labels Sep 7, 2022
@jenn-le jenn-le marked this pull request as ready for review September 7, 2022 22:40
@jenn-le jenn-le requested a review from a team as a code owner September 7, 2022 22:40
function* noopDataConsumer(cursor: ITreeCursor) {
yield undefined;
}

// Helper that measures an optimized 'deepClone()' vs. using ITreeCursor to extract an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is out of date.

@CraigMacomber
Copy link
Contributor

Can you post the results of a benchmark run including these new tests?

jenn-le and others added 5 commits September 7, 2022 16:29
Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
@jenn-le
Copy link
Contributor Author

jenn-le commented Sep 7, 2022

Can you post the results of a benchmark run including these new tests?

image

Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
@jenn-le jenn-le merged commit 6b977d0 into microsoft:main Sep 8, 2022
@jenn-le jenn-le deleted the cursor-benchmarks branch September 8, 2022 02:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants