build: Upgrade pipelines to Node18 + upgrade nvm recommendation

[robertobe-ms]

Update the recommended versions of Node.js for developers to use, as well as the version used by CI, from version 14 to 18.

This change made some scenarios in some e2e tests hang, so a fix for skipping them had to be included.
Details:
0.58.x doesn't have the fix to routerlicious-driver in this PR: #8913
(also see related issue for more context on the problem: #9163)
This causes this test to hang while loading container2, as the snapshot is over 16KB.

[CraigMacomber]

package-lock.json was changed from lock file format 1 to 3. This seems like a bad change since you are trying to stay on the same npm version. Probably revert that file.

[msfluid-bot]

Could not find a usable baseline build with search starting at CI 7920d44

Generated by 🚫 dangerJS against 9855bf1

[tylerbutler]

Nice work getting the CI to pass! I think you can merge now. :) Even if we need to upgrade npm, we can do that separately.

[jason-ha]

Just a few things to comment on or make sure are required changes from me.
Without doing new npm, package-lock.json should probably go back too as Craig suggested.

[tylerbutler]

Just a few things to comment on or make sure are required changes from me. Without doing new npm, package-lock.json should probably go back too as Craig suggested.

I was able to revert all of these file to their lts versions and everything worked locally:

package-lock.json
examples/apps/view-framework-sampler/src/views/reactView.tsx
examples/data-objects/diceroller/src/main.tsx
examples/hosts/app-integration/container-views/src/view.tsx
packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts

I suggest reverting those files and seeing if CI still passes.

[jason-ha]

CI did fail on examples/apps/view-framework-sampler/src/views/reactView.tsx which is what I had seen too. I don't know how your build worked, Tyler. Of course I don't know why it actually fails either. Mysteries of lerna managed dependencies. Home stretch.

---

In reply to: 1743993967

[robertobe-ms]

The packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts file was not reverted because that fix and e2e test that hangs.
For details this is the comment that Abram did in the fix:
0.58.x doesn't have the fix to routerlicious-driver in this PR: #8913
(also see related issue for more context on the problem: #9163)
This causes this test to hang while loading container2, as the snapshot is over 16KB.