Remove unnecessary dependency on server-services-client package

[jikim-msft]

Description

5659

This PR replaces @fluidframework/server-services-client to @fluid-internal/client-utils in the @fluidframework/tinylicious-driver.

[anthony-murphy]

did we consider reducing our dependency over all here. I think in general we could just replace this with uuid. they are a bit less nice, but dropping the dependency overall is probably worth it.

[alexvy86]

did we consider reducing our dependency over all here. I think in general we could just replace this with uuid. they are a bit less nice, but dropping the dependency overall is probably worth it.

Good point... the uses I saw were basically to generate fake user names, where we already use uuid() for a fake user id. Using the first two segments of the same uuid as <first> <last> seems like it would be fine. @jikim-msft once you're done finding all the places where we can make this update, let's see how those packages are using getRandomName(). If that's the only usage pattern (generate a random name for a fake user), I like Tony's suggestion to just remove the function entirely and generate the fake names from the corresponding uuid.

[anthony-murphy]

did we consider reducing our dependency over all here. I think in general we could just replace this with uuid. they are a bit less nice, but dropping the dependency overall is probably worth it.

Good point... the uses I saw were basically to generate fake user names, where we already use uuid() for a fake user id. Using the first two segments of the same uuid as " " seems like it would be fine. @jikim-msft once you're done finding all the places where we can make this update, let's see how those packages are using getRandomName(). If that's the only usage pattern (generate a random name for a fake user), I like Tony's suggestion to just remove the function entirely and generate the fake names from the corresponding uuid.

it should be all test/demo/example. a more involved change would be to allow name injections, but default to uuid, and then directly depend on silly name in the webpack fluid loader, which is what our examples generally use

[jikim-msft]

@alexvy86

Files listed below depend on getRandomName() only for the purpose of assigning random names to the fake user:

• packages/drivers/local-driver/src/auth.ts
• packages/drivers/tinylicious-driver/src/insecureTinyliciousTokenProvider.ts
• packages/tools/webpack-fluid-loader/src/getDocumentServiceFactory.ts

I think we can replace the name to have a first few segments of uuid.

[alexvy86]

I think this makes the intention a bit clearer, can we update them all?

Suggested change

	const userName = userId.match(/^([\da-f]{8})-([\da-f]{4})/); // userName takes the first two segments of the userId.
	const userName = userId.match(/^([\da-f]{8})-([\da-f]{4})/); // Just use the first two segments of the (fake) userId as a fake name

[tylerbutler]

The title of the pr is misleading. Maybe "remove unnecessary dependency on server packages"?