build: Upgrade to latest eslint config #17480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
tylerbutler
commented
Sep 26, 2023
examples/external-data/src/mock-external-data-service/service.ts
Outdated
Show resolved
Hide resolved
⯆ @fluid-example/bundle-size-tests: -10 Bytes
Baseline commit: 746ebdb |
Josmithr
reviewed
Sep 26, 2023
| @@ -3,4 +3,5 @@ | |||
| * Licensed under the MIT License. | |||
| */ | |||
|
|
|||
| // eslint-disable-next-line unicorn/no-empty-file | |||
| describe("Bubblebench", () => {}); | |||
There was a problem hiding this comment.
Should we just delete this file if it has no tests? If these are the only tests in the package, and strictly exist to make the mocha script pass, we should add a comment to that effect.
Josmithr
reviewed
Sep 26, 2023
| @@ -1622,6 +1623,7 @@ export class MergeTree { | |||
| } | |||
|
|
|||
| if ( | |||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- ?? is not logically equivalent when the first clause returns false. | |||
There was a problem hiding this comment.
I almost wonder if we should disable this rule, given how frequently it makes invalid recommendations. I've been burned by its auto-fix behavior in particular before.
There was a problem hiding this comment.
I agree. Letting the linter fix things should be almost a no-brainer, but this particular "fix" requires more careful consideration on a case-by-case basis.
Josmithr
reviewed
Sep 26, 2023
This reverts commit ef72165.
|
/azp run Build - client packages |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
added
base: main
tylerbutler
added a commit
that referenced
this pull request
Oct 13, 2023
While working on #17480, I noticed that some packages had unneeded deps on eslint configs and plugins. I removed those in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the client release group to use the most recent release of the shared eslint config.