Automation: main-next integrate #17516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s DataProcessingError (#17442) When a consumer of FF uses `mixinSummaryHandler` to run additional code before summarization, they introduce risk to the Summarization system where that code could throw and cause summarization to fail. These failures are completely outside the control of FF, but can be catastrophic for a container since persistent failure to summarize can lead to effective document corruption (e.g. ODSP blocks all changes once there are 10k unsummarized ops). So we want to classify these errors as DataProcessingErrors with the codepath `mixinSummaryHandler` mentioned so we and our partners can have immediate insight when these errors arise. Currently, a premier 1P partner is facing a large number of these errors and we are trying to clarify the telemetry signal to be more actionable.
## Description
`forceReadonly` does not work as expected. Doing something like:
```
container.forceReadonly?.(true);
containerMap.set("key1", "1");
containerMap.set("key2", "2");
loaded.forceReadonly?.(false);
<<synchronize>>
```
will cause assert `0x173`, as clearing the readonly flag will not
trigger a new connection but will call the readonly event handler on the
deltamanager, which calls replayPendingStates without a new connection.
We have noticed thousands of hits in our telemetry about this..
The root cause is the redudant `readonly` event handler in the container
runtime, causing the pendig state manager to be called twice. We're
already doing that when the connection state changes.
## Description Tangential to ADO:5524 Regardless of the event category provided to the `logConnectionIssue` function, it will _always_ send the event as an error. This goes against the intention of calls such as https://github.com/microsoft/FluidFramework/blob/441964ed717b0cc03a23d19bdb0fa4b9b4d98871/packages/loader/container-loader/src/connectionStateHandler.ts#L415 -> https://github.com/microsoft/FluidFramework/blob/441964ed717b0cc03a23d19bdb0fa4b9b4d98871/packages/loader/container-loader/src/container.ts#L875
## Description `ddsOpProcessing` and `ddsEventCallbacks` are very noisy in the stress tests, although already sampled. Using the feature gate, we should publish only 10% of the existing volume (we're already sampling them 1/1000).
Results of running `pnpm run policy-check:asserts` on the main branch.
⯆ @fluid-example/bundle-size-tests: -320 Bytes
Baseline commit: 8220392 |
tylerbutler
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-lease