Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation: main-next integrate #17534

Closed
wants to merge 7 commits into from
Closed

Automation: main-next integrate #17534

wants to merge 7 commits into from

Conversation

msfluid-bot
Copy link
Collaborator

main-next integrate PR

The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:

  1. Acknowledge the pull request by adding a comment -- "Actively working on it".
  2. If there are no CI failures, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.
  3. If there are CI failures, check out the main-next-0425aa1 branch and make code changes to fix the failures.
  • You can ignore any failures in the Real service e2e test and Stress test pipelines. These pipelines are not required to pass to merge changes.
  1. Do NOT rebase or squash the main-next-0425aa1 branch: its history must be preserved. Always amend the HEAD commit using the following git commands:
  • git commit --amend -m "Automation: main-next integrate"
  • git push --force-with-lease

dependabot bot and others added 7 commits September 27, 2023 19:08
…rk (#17525)

Bumps [get-func-name](https://github.com/chaijs/get-func-name) from
2.0.0 to 2.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/chaijs/get-func-name/releases">get-func-name's
releases</a>.</em></p>
<blockquote>
<h2>v2.0.2</h2>
<h2>What's Changed</h2>
<p>Revert previous changes that shipped this as an ES module.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/chaijs/get-func-name/commits/v2.0.2">https://github.com/chaijs/get-func-name/commits/v2.0.2</a></p>
<h2>v2.0.1</h2>
<h2>What's Changed</h2>
<p>Fix <a
href="https://github.com/chaijs/get-func-name/security/advisories/GHSA-4q6p-r6v2-jvc5">https://github.com/chaijs/get-func-name/security/advisories/GHSA-4q6p-r6v2-jvc5</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/chaijs/get-func-name/commits/v2.0.1">https://github.com/chaijs/get-func-name/commits/v2.0.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a
href="https://github.com/chaijs/get-func-name/commits/v2.0.2">compare
view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a
href="https://www.npmjs.com/~keithamus">keithamus</a>, a new releaser
for get-func-name since your current version.</p>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=get-func-name&package-manager=npm_and_yarn&previous-version=2.0.0&new-version=2.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/microsoft/FluidFramework/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds an intro suite of unit tests for `LazyOptionalField`. Specifically,
adds tests for the following properties and methods:
* `is`
* `length`
* `map`
* `mapBoxed`

---------

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
## Description

This replaces the current iterator behavior of the editable tree types
to be specific to the type of tree object, and in general favors
unboxing. The existing iteration behavior (which keeps nodes and fields
boxed) has been moved to a method called `[boxedIterator]()`.

## Breaking Changes

The behavior of node and field iterators has been moved to
`[boxedIterator]()`.
Updates the dependency on `@fluid-tools/api-markdown-documenter` and
applies necessary fixes to accommodate breaking changes in the library.

Changes include:
* Add custom `DocumentationNode` implementation `AlertNode` (which was
previously a type in the library, but was removed)
  * See `alert-node.js` and `custom-renderers.js`
* Specifying a custom `createDefaultLayout` lambda
* Allows us to use the custom `AlertNode`, and will allow us to more
flexibly adjust page layout in the future.
  * See `api-documentation-layout.js`
## Description

Related to ADO:5682

This change adds the capability to sample measure performance events per
(event name + event category) and enables this for the noisy event.

---------

Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
@msfluid-bot
Copy link
Collaborator Author

msfluid-bot commented Sep 28, 2023

@fluid-example/bundle-size-tests: +9.34 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 443.71 KB 443.96 KB +261 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 237.04 KB 237.29 KB +261 Bytes
loader.js 148.13 KB 148.39 KB +261 Bytes
map.js 46.46 KB 48.43 KB +1.98 KB
matrix.js 140.24 KB 142.21 KB +1.98 KB
odspDriver.js 90.2 KB 90.46 KB +261 Bytes
odspPrefetchSnapshot.js 41.87 KB 42.13 KB +261 Bytes
sharedString.js 160.89 KB 162.86 KB +1.98 KB
sharedTree2.js 255.73 KB 257.88 KB +2.14 KB
Total Size 1.67 MB 1.68 MB +9.34 KB

Baseline commit: 2163145

Generated by 🚫 dangerJS against 0425aa1

@andre4i
Copy link
Contributor

andre4i commented Sep 28, 2023

@NicholasCouri @alexvy86 about the Perf benchmark test

@andre4i andre4i closed this Sep 28, 2023
@andre4i andre4i reopened this Sep 28, 2023
@andre4i
Copy link
Contributor

andre4i commented Sep 28, 2023

Performance benchmarks (Perf unit tests - runtime Run tests

The failure seems transient? However, hitting 're-run' doesn't re-run it. Closing -> Opening the PR scheduled all other test runs, except for this one. Anyone have any ideas? @tylerbutler @sonalideshpandemsft

This was assigned to me as I did the last commit, which seems unrelated to this test failure.

@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start http://localhost:1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://localhost:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> fluidframework-docs@0.25.0 ci:start
> http-server ./public --port 1313 --silent


> fluidframework-docs@0.25.0 linkcheck:full
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/apis/runtime-definitions/
- (1703:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)
- (1703:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)

http://localhost:1313/docs/apis/tree/
- (4170:210) 'https://..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-utils/src/error.ts (HTTP 404)
- (4170:210) 'https://..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-utils/src/error.ts (HTTP 404)

http://localhost:1313/docs/build/bundlers/
- (843:233) 'here' => https://github.com/microsoft/FluidFramework/blob/a4c38234a920abe9b54b1c26a14c0a8e430cd3fa/packages/tools/webpack-fluid-loader/webpack.config.js#L37 (HTTP 200 but missing anchor)

http://localhost:1313/docs/deployment/service-options/
- (848:72) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)
- (850:168) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)

http://localhost:1313/docs/faq/
- (927:87) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)

http://localhost:1313/docs/testing/telemetry/
- (848:3) 'ILoaderP..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-loader/src/loader.ts#L313 (HTTP 200 but missing anchor)


Summary of most serious issues:

http://localhost:1313/docs/apis/runtime-definitions/
- (1703:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)
- (1703:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)

http://localhost:1313/docs/apis/tree/
- (4170:210) 'https://..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-utils/src/error.ts (HTTP 404)
- (4170:210) 'https://..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-utils/src/error.ts (HTTP 404)


Stats:
  207480 links
    2021 destination URLs
       2 URLs ignored
       5 warnings
       2 errors

 ELIFECYCLE  Command failed with exit code 1.

@alexvy86
Copy link
Contributor

One stage of perf benchmarks has been broken for a while, we discovered recently. It shouldn't run for PRs though. Not sure if for main-next automation, since the commit in main did get perf benchmarks run as part of its internal CI, that's why we see it here? But I would've expected many more main-next integrations to have the same symptom and I don't think they have... or we've been ignoring it? IMO it's safe to ignore that pipeline failure if it's the only one.

@sonalideshpandemsft
Copy link
Contributor

sonalideshpandemsft commented Sep 29, 2023

closing and opening a new PR. I don't see the merge commit with the name Automation: main-next integrate on this one. weird

thanks @andre4i, @alexvy86!! not sure why the merge commit is not included in this PR.

I opened a new PR: #17549. This PR has the merge commit: 128dedd8a428372b453f2ccbcb64ce175895fb2c which was missing in this PR.

@sonalideshpandemsft sonalideshpandemsft deleted the main-next-0425aa1 branch September 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: next PRs targeted against next branch main-next-integrate merge-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants