chore(merge-tree sequence examples): remove NestBegin and NestEnd reference types #17546

connorskees · 2023-09-29T02:45:56Z

This is a ~conservative first pass at removing some of the tech debt related to the NestBegin and NestEnd reference types. Alongside these enum variants, this change removes getStackContext, RangeStackMap, the shared-text example, and a few other things.

I will add some review comments to call out some changes (or lack thereof) to make sure they make sense once CI is green.

…erence types

api-report/merge-tree.api.md

connorskees · 2023-09-29T03:43:34Z

examples/data-objects/prosemirror/src/fluidBridge.ts

For prosemirror, the example seems good enough if we just do some finagling with the reference types. That said, it's not clear to me which reference type these should switch to, and the APIs being used appear quite old. I'm not sure if we want to remove this example entirely.

connorskees · 2023-09-29T03:44:02Z

examples/data-objects/shared-text/.eslintrc.js

shared-text uses a lot of merge-tree internals, and it seems best just to delete entirely.

examples/data-objects/webflow/src/clipboard/paste.ts

connorskees · 2023-09-29T03:45:19Z

packages/dds/merge-tree/src/localReference.ts

+			if (refHasTileLabels(lref)) {
 				this.hierRefCount++;


I kept hierRefCount and the tiles stuff around as I wasn't sure if they were safe to remove.

connorskees · 2023-09-29T03:45:56Z

packages/dds/merge-tree/src/mergeTree.ts

 	}

 	public hierBlock() {
 		return this;
 	}
-
-	public hierToString(indentCount: number) {


This didn't seem to have any usage anywhere

connorskees · 2023-09-29T03:46:56Z

packages/dds/sequence/src/test/testFarm.ts

See also: 9dc1859

i'm ~intending to revert this change, but for now the webflow build seems quite broken and i want to see the test run results in CI

msfluid-bot · 2023-09-29T05:00:40Z

⯆ @fluid-example/bundle-size-tests: -5.9 KB

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	443.96 KB	441.95 KB	⯆ -2.01 KB
connectionState.js	680 Bytes	680 Bytes	■ No change
containerRuntime.js	237.29 KB	237.29 KB	■ No change
loader.js	148.39 KB	148.39 KB	■ No change
map.js	48.43 KB	48.43 KB	■ No change
matrix.js	142.21 KB	140.32 KB	⯆ -1.89 KB
odspDriver.js	90.46 KB	90.46 KB	■ No change
odspPrefetchSnapshot.js	42.13 KB	42.13 KB	■ No change
sharedString.js	162.86 KB	160.87 KB	⯆ -2 KB
sharedTree2.js	258.88 KB	258.88 KB	■ No change
Total Size	1.68 MB	1.67 MB	⯆ -5.9 KB

Baseline commit: 550e869

Generated by 🚫 dangerJS against 57f94c5

anthony-murphy

we need to do some deprecations in main for completeness, but i highly doubt any of this is in use. we also need a changeset here to call out the removals in mergetree/seq, keep it brief, as again, i don't think its used, as this stuff probably doesn't work anyway.

anthony-murphy

actually, can we bring back web flow and test farm, feel free to rip features out, but i'd like to keep both. might make sense to do this with the deprecations in main

a couple changes

connorskees · 2023-09-29T17:46:51Z

testFarm wasn't deleted in this PR, it just has a lot of lines deleted. I did delete it in #17547, however.

This reverts commit 61e4d8b.

connorskees · 2023-09-29T18:37:41Z

Deprecation PR: #17555

anthony-murphy · 2023-09-29T21:24:25Z

packages/dds/sequence/src/intervals/sequenceInterval.ts

@@ -577,8 +577,7 @@ export function createSequenceInterval(
 		endRefType = ReferenceType.Transient;
 	} else {
 		if (intervalType === IntervalType.Nest) {


i think we should also deprecate IntervalType.Nest

) Deprecations for #17546

github-actions · 2023-10-02T18:46:54Z

This PR is ready to merge! Please review it and squash merge into next: @sonalideshpandemsft @tylerbutler @scottn12

chore(merge-tree sequence examples): remove NestBegin and NestEnd Ref…

7f2692e

…erence types

connorskees requested review from msfluid-bot and a team as code owners September 29, 2023 02:45

github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: examples Changes that focus on our examples public api change Changes to a public API base: next PRs targeted against next branch labels Sep 29, 2023

connorskees added 2 commits September 29, 2023 03:38

fix undo-redo build

48c86ee

fix webflow build

38abbc0

github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Sep 29, 2023

connorskees commented Sep 29, 2023

View reviewed changes

delete webflow

61e4d8b

i'm ~intending to revert this change, but for now the webflow build seems quite broken and i want to see the test run results in CI

connorskees requested a review from Abe27342 September 29, 2023 05:01

anthony-murphy previously approved these changes Sep 29, 2023

View reviewed changes

anthony-murphy reviewed Sep 29, 2023

View reviewed changes

connorskees added 2 commits September 29, 2023 18:07

merge next

c93407e

Revert "delete webflow"

d95179a

This reverts commit 61e4d8b.

connorskees requested a review from a team as a code owner September 29, 2023 18:08

github-actions bot added the dependencies Pull requests that update a dependency file label Sep 29, 2023

update lock file

14b8668

connorskees mentioned this pull request Sep 29, 2023

chore(merge-tree): deprecations related to NestEnd and NestBegin #17555

Merged

connorskees added 2 commits September 29, 2023 18:50

add changeset

d8bff7a

fix webflow tests

76c2f06

connorskees requested a review from anthony-murphy September 29, 2023 21:03

anthony-murphy reviewed Sep 29, 2023

View reviewed changes

remove IntervalType.Nest

66c07d5

connorskees added a commit that referenced this pull request Sep 29, 2023

chore(merge-tree): deprecations related to NestEnd and NestBegin (#17555

e4c1187

) Deprecations for #17546

merge next

57f94c5

anthony-murphy approved these changes Oct 2, 2023

View reviewed changes

connorskees added the msftbot: merge-next label Oct 2, 2023

tylerbutler merged commit c426adf into microsoft:next Oct 2, 2023
33 checks passed

connorskees deleted the chore/remove-nest-reference-types branch October 13, 2023 20:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(merge-tree sequence examples): remove NestBegin and NestEnd reference types #17546

chore(merge-tree sequence examples): remove NestBegin and NestEnd reference types #17546

connorskees commented Sep 29, 2023

connorskees Sep 29, 2023

connorskees Sep 29, 2023

connorskees Sep 29, 2023 •

edited

connorskees Sep 29, 2023

connorskees Sep 29, 2023

msfluid-bot commented Sep 29, 2023 •

edited

anthony-murphy left a comment

anthony-murphy left a comment •

edited

connorskees commented Sep 29, 2023

connorskees commented Sep 29, 2023

anthony-murphy Sep 29, 2023

github-actions bot commented Oct 2, 2023

chore(merge-tree sequence examples): remove NestBegin and NestEnd reference types #17546

chore(merge-tree sequence examples): remove NestBegin and NestEnd reference types #17546

Conversation

connorskees commented Sep 29, 2023

connorskees Sep 29, 2023

Choose a reason for hiding this comment

connorskees Sep 29, 2023

Choose a reason for hiding this comment

connorskees Sep 29, 2023 • edited

Choose a reason for hiding this comment

connorskees Sep 29, 2023

Choose a reason for hiding this comment

connorskees Sep 29, 2023

Choose a reason for hiding this comment

msfluid-bot commented Sep 29, 2023 • edited

anthony-murphy left a comment

Choose a reason for hiding this comment

anthony-murphy left a comment • edited

Choose a reason for hiding this comment

connorskees commented Sep 29, 2023

connorskees commented Sep 29, 2023

anthony-murphy Sep 29, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 2, 2023

connorskees Sep 29, 2023 •

edited

msfluid-bot commented Sep 29, 2023 •

edited

anthony-murphy left a comment •

edited