Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge-tree sequence): misc cleanup #17547

Merged
merged 9 commits into from Oct 3, 2023

Conversation

connorskees
Copy link
Member

Misc cleanup tasks for merge-tree and sequence. See the commits for a breakdown of the changes.

Potentially controversially, this PR deletes the sequence testFarm. As far as I can tell, this file is never actually executed. I am interested to know if that's not the case.

either fix usages of the <T> casting syntax, or make unsafe casts more
explicit through an intermediate cast to any
i think this is never run? additionally, much of its code is duplicated
between beastTest.ts in merge-tree or just completely disabled
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring public api change Changes to a public API base: next PRs targeted against next branch labels Sep 29, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Sep 29, 2023

@fluid-example/bundle-size-tests: +209 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 441.95 KB 442.01 KB +70 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 237.29 KB 237.29 KB No change
loader.js 148.39 KB 148.39 KB No change
map.js 48.43 KB 48.43 KB No change
matrix.js 140.32 KB 140.39 KB +70 Bytes
odspDriver.js 90.46 KB 90.46 KB No change
odspPrefetchSnapshot.js 42.13 KB 42.13 KB No change
sharedString.js 160.87 KB 160.94 KB +69 Bytes
sharedTree2.js 258.88 KB 258.88 KB No change
Total Size 1.67 MB 1.67 MB +209 Bytes

Baseline commit: 7fde01a

Generated by 🚫 dangerJS against 6a0ef02

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This PR is ready to merge! Please review it and squash merge into next: @sonalideshpandemsft @tylerbutler @scottn12

@tylerbutler
Copy link
Member

@connorskees Looks like there are some merge conflicts now (maybe because I merged another PR in?). Once resolved let me know and I'll hit the button.

@tylerbutler tylerbutler merged commit 311c1ea into microsoft:next Oct 3, 2023
33 checks passed
@connorskees connorskees deleted the chore/misc-mt-cleanup branch October 13, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures base: next PRs targeted against next branch msftbot: merge-next public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants