New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(merge-tree sequence): misc cleanup #17547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
either fix usages of the <T> casting syntax, or make unsafe casts more explicit through an intermediate cast to any
i think this is never run? additionally, much of its code is duplicated between beastTest.ts in merge-tree or just completely disabled
⯅ @fluid-example/bundle-size-tests: +209 Bytes
Baseline commit: 7fde01a |
…to chore/misc-mt-cleanup
anthony-murphy
approved these changes
Oct 2, 2023
|
This PR is ready to merge! Please review it and squash merge into |
|
@connorskees Looks like there are some merge conflicts now (maybe because I merged another PR in?). Once resolved let me know and I'll hit the button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: sharedstring
area: dds
Issues related to distributed data structures
base: next
PRs targeted against next branch
msftbot: merge-next
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc cleanup tasks for merge-tree and sequence. See the commits for a breakdown of the changes.
Potentially controversially, this PR deletes the sequence testFarm. As far as I can tell, this file is never actually executed. I am interested to know if that's not the case.