Unify and Fix Handling of Test Content #17590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
anthony-murphy
commented
Oct 2, 2023
| @@ -146,8 +147,6 @@ export async function processOneNode(args: IWorkerArgs) { | |||
| export async function processContent(mode: Mode, concurrently = true) { | |||
| const limiter = new ConcurrencyLimiter(numberOfThreads); | |||
|
|
|||
| ensureTestCollateralPath(); | |||
There was a problem hiding this comment.
this is redundant, getFileLocations fails if it doesn't find the content
github-actions
bot
added
the
dependencies
connorskees
approved these changes
Oct 3, 2023
|
Seems fine to me. Previously, it wasn't possible to run part of the snapshot tests locally? |
yeah. when i tried to run packages/test/snapshots/src/test/serialized.spec.ts, they just skipped themselves due to bad path construction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization tests were incorrectly creating the path for the text content, and not running locally. this change unifies how we create paths for test content, and will fail if the test content doesn't exist in automation.