Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster capacity request #18262

Merged
merged 4 commits into from Nov 13, 2023
Merged

Conversation

taylorsw04
Copy link
Contributor

Description

This change annotates the compressor creation ranges with the desired cluster size. This allows for future "smart" request policies without needed to make a format change, as the policy can be run by one client without sequencing.

Breaking Changes

This breaks the IdCompressor persisted format, but no code yet uses it so this is acceptable.

@taylorsw04 taylorsw04 requested review from msfluid-bot and a team as code owners November 10, 2023 22:56
@github-actions github-actions bot added area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: next PRs targeted against next branch labels Nov 10, 2023

/**
* Roughly equates to a minimum of 1M sessions before we start allocating 64 bit IDs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I still think the contents here belong in a @remarks block, and that the addition of a semantic description would be useful.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -4.17 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 442.93 KB 442.23 KB -726 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 239.31 KB 238.6 KB -726 Bytes
loader.js 178.97 KB 178.97 KB No change
map.js 48.06 KB 47.39 KB -687 Bytes
matrix.js 139.01 KB 138.34 KB -687 Bytes
odspDriver.js 90.27 KB 90.27 KB No change
odspPrefetchSnapshot.js 41.9 KB 41.9 KB No change
sharedString.js 159.54 KB 158.87 KB -687 Bytes
sharedTree2.js 261.67 KB 261 KB -687 Bytes
Total Size 1.71 MB 1.71 MB -4.17 KB

Baseline commit: 6c62904

Generated by 🚫 dangerJS against d75b9fe

@connorskees
Copy link
Member

Out of curiosity, did you close #18231 and re-open to avoid the UI clutter in GitHub when you change the base branch?

E.g.

image

@taylorsw04 taylorsw04 merged commit 1bc3dbc into microsoft:next Nov 13, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants