Merged
Conversation
Josmithr
reviewed
Nov 10, 2023
packages/runtime/runtime-definitions/src/id-compressor/persisted-types/0.0.1.ts
Show resolved
Hide resolved
Josmithr
reviewed
Nov 10, 2023
| // ----- Ephemeral state ----- | ||
|
|
||
| /** | ||
| * Roughly equates to a minimum of 1M sessions before we start allocating 64 bit IDs. |
Contributor
There was a problem hiding this comment.
Nit: I still think the contents here belong in a @remarks block, and that the addition of a semantic description would be useful.
justus-camp
approved these changes
Nov 10, 2023
Collaborator
⯆ @fluid-example/bundle-size-tests: -4.17 KB
Baseline commit: 6c62904 |
Contributor
|
Out of curiosity, did you close #18231 and re-open to avoid the UI clutter in GitHub when you change the base branch? E.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This change annotates the compressor creation ranges with the desired cluster size. This allows for future "smart" request policies without needed to make a format change, as the policy can be run by one client without sequencing.
Breaking Changes
This breaks the IdCompressor persisted format, but no code yet uses it so this is acceptable.