Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(type-tests): return void from use function #18268

Closed
wants to merge 2 commits into from
Closed

feat(type-tests): return void from use function #18268

wants to merge 2 commits into from

Conversation

connorskees
Copy link
Member

this removes the implicit any return from the use_old functions. this is a necessary step to enable noImplicitAny in our test packages

@connorskees
feat(type-tests): return void from use function
1c09095 
this removes the implicit any return from the use_old functions. this is
a necessary step to enable noImplicitAny in our test packages
@connorskees connorskees requested review from a team as code owners November 11, 2023 02:13
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: sharedstring area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Nov 11, 2023
@connorskees
Copy link
Member Author

Relevant changes are to build-tools/packages/build-tools/src/typeValidator/testGeneration.ts

@tylerbutler
Copy link
Member

Unfortunately you won't be able to make the build-tools change and the client change in a single PR since they're in different release groups. You'll have to make the build-tools change then we need to release and integrate it into client.

@connorskees
Copy link
Member Author

connorskees commented Nov 11, 2023 •
edited

release and integrate it into client

Is it sufficient to just merge the build-tool change into main and bump the dependency version in this PR, or is there a special release process that must be followed?

@connorskees connorskees mentioned this pull request Nov 13, 2023
Merged
connorskees added a commit that referenced this pull request Nov 14, 2023
@connorskees
feat(type-tests): explicitly return void in type-test function (#18282)
b1165d8 
See #18268 for
additional context. This is a necessary step in enabling `noImplicitAny`
in more packages and globally.
@github-actions github-actions bot removed the area: build Build related issues label Nov 14, 2023
@connorskees
Copy link
Member Author

Closing as this will be handled by a build-tools bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@connorskees @tylerbutler