Automation: main-next integrate #18269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policy handlers are now async, which enables them to more easily use async libraries to perform checks. Note that resolvers and "final" handlers are still synchronous. I also updated the names of some functions and variables to make it clearer what they're doing. In particular the "runPolicyCheck" function was very wrong - it only executed the final handlers so it's a lot clearer post-rename.
changeset removed was missed as part of azure cleanup. This PR removes the changeset from `azure/`
#18131) Removes the need for the following cast: ```ts const { container } = await client.createContainer({ initialObjects: { myMap: SharedMap, } }); const myMap = container.initialObjects.myMap as SharedMap; // <== 'as SharedMap' no longer needed. ``` --------- Co-authored-by: Matt Rakow <ChumpChief@users.noreply.github.com> Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
This PR updates a handful of packages to use dts trimming. As far as we know, the rollups don't differ between CJS and ESNext builds, so we just copy the rollups from the CJS build into the ESNext build output. If we find this causes problems, then the alternative is similar to what we do with tsconfigs - we create a new config file, api-extractor.esnext.json, and then we add a task to package.json to run api-extractor using that new config file. This is the most "correct" way to do this since it runs api-extractor both times, using the CJS and ESNext source as appropriate. However, that method is slow because it calls api-extractor twice, so we're going to use the copy method until we find we can't. This PR does not change to use a trimmed type file, like public. We can make those changes separately. This PR just enables building the trimmed files. [AB#6146](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/6146)
… package READMEs with experimental notice (#18208) The idea here is to start adding an explicit notice to library package READMEs (as needed) to denote their experimental nature. Especially while we are stuck with some legacy package namespaces (preventing us from moving some experimental things, like `ink` into `@fluid-experimental`), this gives us a top-level mechanism for communicating the experimental status of a package to consumers who may find the package in our github or on npm. See updated test document for an example. --------- Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
…17726) [AB#5312](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5312) ## Description This PR enables and connects Op Latency Telemetry to the front end component.  If telemetry sampling has not been disabled, users see the following screen 
… and `@fluid-private` (#18223) Follow up to #18208 - adds support for generated library package notices for internal and private packages. Replaces `README_PRIVATE_PACKAGE_NOTICE` with `README_PACKAGE_SCOPE_NOTICE`, which can handle all the cases we care about, and can automatically inherit the correct behavior from the package's namespace. Also updates some package READMEs to take better advantage of the templates. --------- Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
## Description Editable tree now excepts new content in the form of cursors. Alos included are some testing cleanups to avoid depending on SharedTree for testing editable tree, and some improved coverage on the editing methods of fields which were previously entirely untested. ## Breaking Changes Code that was violating the type system and providing cursors already for list insertion methods happened to work, but now requires a single field cursor instead of an array of node cursors (and no longer violates the typing).
For `PendingStateManager` change, a cleanup item was never opened to remove the property from `IPendingMessage` #14434. For `OpGroupingManager`, the `clientSequenceNumber` would currently represent 2 separate concepts: index in batch, and actual clientSequenceNumber. We should only present one of these concepts at a time depending on if grouped batching is enabled or not.
…led (#18229) ## Description Currently, if TelemetryContext is enabled, telemetry uses the correlationId from TelemetryContext, but the response header for correlationId still comes from the old `bindCorrelationId` middleware because it overwrites TelemetryContext's header.
## Description The new Nexus service was not added to the server/docker-compose*.yml files, so running R11s that way does not work with AzureClient because it can't find Nexus. This isn't terrible, since I think I'm one of very few people who use docker-compose.dev.yml, but would be nice to have it fixed.
…in READMEs that weren't using them for trademarks (#18230) The existing template had been line-wrapped in the middle of link text, which broke the link syntax. This PR fixes the template, updates existing usages, and adds new usages of the markdown-magic pragma where we weren't using it.
Adds basic support for tsc-multi tasks in fluid-build. Also updates some fluid-build-related policy handlers to treat tsc-multi as equivalent to tsc. My goal with these changes is to unblock further work, so I'm only aiming for basic support. Any bells and whistles can wait.
## Description This better formalizes the convention of using above root placeholder nodes, leverages this to provide field cursor builders, and makes cursor related function naming more consistent. ## Breaking Changes Some cursor related functions have been renamed and had argument order changed, but nothing was removed.
…errors (#18243) Remove args from Redis errors since args may contain sensitive information such as tokens Co-authored-by: Yunpeng Hou <yunho-microsoft@Yunho-MacBookPro2019.local>
⯆ @fluid-example/bundle-size-tests: -47 Bytes
Baseline commit: 9a360ba |
sonalideshpandemsft
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.