Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dts-trimming for packages/common #18271

Merged
merged 3 commits into from Nov 13, 2023
Merged

Enable dts-trimming for packages/common #18271

merged 3 commits into from Nov 13, 2023

Conversation

jikim-msft
Copy link
Contributor

@jikim-msft jikim-msft commented Nov 11, 2023 •
edited

Description

Related: 18176

This PR adds type-trimming for packages/common directory. The changes introduced are:

  • Add npm copyfiles package as devDependency
  • Add dtsRollup in api-extractor.json
  • Enable both type-trimming for both ESM & CJS
  • Make fluidBuild to fetch dependencies from the scripts included in dependsOn

@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 11, 2023
@jikim-msft jikim-msft marked this pull request as ready for review November 13, 2023 19:35
@jikim-msft jikim-msft requested review from msfluid-bot and a team as code owners November 13, 2023 19:35
@tylerbutler
Copy link
Member

What about container-definitions and core-interfaces? Are those going to be done separately?

@jikim-msft
Copy link
Contributor Author

jikim-msft commented Nov 13, 2023 •
edited

What about container-definitions and core-interfaces? Are those going to be done separately?

I believe the work on commons/container-definitions and commons/core-interfaces are already completed from your previous work on the dts-trimming 18176.

container-definitions/api-extractor.json: Link
container-definitions/package.json: Link

core-interfaces/api-extractor.json: Link
container-definitions/package.json: Link

I also see the alpha, beta and public d.ts files correctly generated in dist folder for those packages in the main branch.

@tylerbutler
Copy link
Member

What about container-definitions and core-interfaces? Are those going to be done separately?

I believe the work on commons/container-definitions and commons/core-interfaces are already completed from your previous work on the dts-trimming 18176.

container-definitions/api-extractor.json: Link container-definitions/package.json: Link

core-interfaces/api-extractor.json: Link container-definitions/package.json: Link

I also see the alpha, beta and public d.ts files correctly generated in dist folder for those packages in the main branch.

Ha, forgot I did that. Sorry! :)

tylerbutler
tylerbutler approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jikim-msft jikim-msft merged commit 82651ab into microsoft:main Nov 13, 2023
25 checks passed
@jikim-msft jikim-msft deleted the packages-common/enable-type-trimming branch November 13, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

@Josmithr Josmithr Awaiting requested review from Josmithr

Assignees
No one assigned
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jikim-msft @tylerbutler