New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SharedTree to docs #18272
Add SharedTree to docs #18272
Conversation
|
Please ignore if this was already the plan, but we should probably wait to merge this until we release the 2.0 beta, otherwise we may cause some confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since FF 2.0 will only be available in beta in the near future, it seems like we should be careful to note this anywhere we are covering 2.0-specific topics in the docs. E.g. SharedTree.
And for notices about things being deprecated in 2.0, we should probably say "will be deprecated in 2.0" rather than "is deprecated in 2.0".
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
@Rick-Kirkham I've set up a staging branch to put all of the content updates for the 2.0 beta. Once we're ready on Monday, we'll merge that branch into main to publish everything at once. I'm re-targeting this PR to that staging branch so we can merge it now and start testing the site updates before Monday. FYI 🙂 |
|
[like] Ricky Kirkham reacted to your message:
…________________________________
|
Reviewer Guidance
When referring to the children of objects, I used the words "property" or "node." I did not use the word "field." FWIW, I asked ChatGPT 3.5 and other AIs which is the correct term for JavaScript and TypeScript and they all said "property." Also, ChatGPT pointed out the "field" is used for members of TypeScript classes and a TypeScript class property is wrapped around a field, but is not itself a field, so I think it is potentially misleading to refer to the "fields" of an object.